adduser/passwd: too long username

[Laszlo Papp]

On Tue, Aug 5, 2014 at 8:34 PM, Laszlo Papp <lpapp at kde.org> wrote:

> On Tue, Aug 5, 2014 at 7:16 PM, Denys Vlasenko <vda.linux at googlemail.com>
> wrote:
>
>> On Mon, Aug 4, 2014 at 7:06 PM, Laszlo Papp <lpapp at kde.org> wrote:
>> > sudo busybox adduser
>> >
>> fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
>> > passwd: unknown user
>> >
>> fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
>> >
>> > Yet, the user is created in /etc/shadow:
>> >
>> >
>> fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff:!:16286:0:99999:7:::
>> >
>> > This is at least one issue, but there is another here:
>> >
>> > sudo busybox deluser
>> >
>> fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
>> > deluser: unknown user
>> >
>> fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
>>
>> Both issues come from the same location in codebase:
>> bb__pgsreader() parser drops lines which are longer than its buffer.
>>
>> Effectively, bbox ignores offending line in /etc/passwd.
>>
>> > Could you please look into this and potentially fix it? Thanks in
>> advance.
>>
>> Anyone willing to rewrite getpwnam API to use variable-sized malloced
>> buffer?
>>
>
> Is that a junior job?
>

Denys, this fix was sent two weeks ago? Why have you not applied it until
there is a better fix (if any)? This is still broken and results a system
with potential stray users around.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20140817/3b417fd8/attachment.html>