Fix the addgroup help output

Laszlo Papp lpapp at kde.org
Wed Aug 13 10:13:10 UTC 2014


On Wed, Aug 13, 2014 at 9:52 AM, Laszlo Papp <lpapp at kde.org> wrote:

> commit 55d6582d88470078cef09f52d1bc3c9c3f7fca6a
> Author: Laszlo Papp <lpapp at kde.org>
> Date:   Wed Aug 13 09:48:08 2014 +0100
>
>     Fix the addgroup help output
>
>     Since the applet has two options, it is quite misleading to only
> mention one in
>     the usage example. It should either use OPTIONS there or enumerate the
> possible
>     options. The latter seems to be more common in applet, so I picked
> that one.
>
> diff --git a/loginutils/addgroup.c b/loginutils/addgroup.c
> index 22cd0e6..ce57459 100644
> --- a/loginutils/addgroup.c
> +++ b/loginutils/addgroup.c
> @@ -11,7 +11,7 @@
>   */
>
>  //usage:#define addgroup_trivial_usage
> -//usage:       "[-g GID] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ") "GROUP"
> +//usage:       "[-gS] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ") "GROUP"
>  //usage:#define addgroup_full_usage "\n\n"
>  //usage:       "Add a group " IF_FEATURE_ADDUSER_TO_GROUP("or add a user
> to a group") "\n"
>  //usage:     "\n       -g GID  Group id"
>

Hmm, actually, I got some doubts whether this change is useful because
while it fixes one issue, the applets seem randomly inconsistent, e.g. this
is not holding any consistency with any other either:

Usage: crond -fbS -l N -d N -L LOGFILE -c DIR

At best, it is missing the brackets, but the applets are inconsistent at
large overall, sadly, so I am not sure it is any improvement to fix this
one on its own, and fixing all would be more intrusive than I care.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20140813/ddf6a205/attachment.html>


More information about the busybox mailing list