Fix the addgroup help output

Laszlo Papp lpapp at kde.org
Wed Aug 13 10:09:06 UTC 2014


Yeah, I see that you are confused, please read the commit message carefully:

"The latter seems to be more common in applet, so I picked that one."

Have you even tried to run other applets to see their help output? To me,
it seems that you have not investigated anything before chiming in.

On Wed, Aug 13, 2014 at 10:55 AM, walter harms <wharms at bfs.de> wrote:

>
>
> Am 13.08.2014 10:52, schrieb Laszlo Papp:
> > commit 55d6582d88470078cef09f52d1bc3c9c3f7fca6a
> > Author: Laszlo Papp <lpapp at kde.org>
> > Date:   Wed Aug 13 09:48:08 2014 +0100
> >
> >     Fix the addgroup help output
> >
> >     Since the applet has two options, it is quite misleading to only
> > mention one in
> >     the usage example. It should either use OPTIONS there or enumerate
> the
> > possible
> >     options. The latter seems to be more common in applet, so I picked
> that
> > one.
> >
> > diff --git a/loginutils/addgroup.c b/loginutils/addgroup.c
> > index 22cd0e6..ce57459 100644
> > --- a/loginutils/addgroup.c
> > +++ b/loginutils/addgroup.c
> > @@ -11,7 +11,7 @@
> >   */
> >
> >  //usage:#define addgroup_trivial_usage
> > -//usage:       "[-g GID] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ")
> "GROUP"
> > +//usage:       "[-gS] " IF_FEATURE_ADDUSER_TO_GROUP("[USER] ") "GROUP"
> >  //usage:#define addgroup_full_usage "\n\n"
> >  //usage:       "Add a group " IF_FEATURE_ADDUSER_TO_GROUP("or add a user
> > to a group") "\n"
> >  //usage:     "\n       -g GID  Group id"
> >
>
>
> I am confused.
> the original help said:
> [ -g GID]    = option -g with Argument GID
> you version is:
> [ -gS ]      = option -g with Argument S  ??
>
> This was you intention ?
>
> re,
>  wh
>
>
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20140813/c2813cb4/attachment.html>


More information about the busybox mailing list