vi Undo patch

Denys Vlasenko vda.linux at googlemail.com
Thu Apr 3 10:50:09 UTC 2014


On Thu, Apr 3, 2014 at 2:48 AM, Jody Lee Bruchon <jody at jodybruchon.com> wrote:
> I need to review the use of last_file_modified to see if it is
> actually doing something valuable there; it has no clear comments
> and I really dislike that.

How about this: s/file_modified/modified_count/
and:

        // count_lines() is expensive.
        // Call it only if something was changed since last time
        // we were here:
        if (modified_count != last_modified_count) {
                tot = cur + count_lines(dot, end - 1) - 1;
                last_modified_count = modified_count;
        }


More information about the busybox mailing list