testsuite and "bashisms"

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Sun Nov 10 21:08:06 UTC 2013


On 10 November 2013 17:19, Michael Tokarev <mjt at tls.msk.ru> wrote:
> 10.11.2013 20:09, Michael Tokarev wrote:
>>
>> 10.11.2013 19:39, Michael Tokarev wrote:
>>>
>>> 10.11.2013 19:25, Michael Tokarev wrpte:
>>>>
>>>> Another question/issue with the testsuite.
>>>> '
>>>> The testsuite uses ${var/search/replace} construct
>>>> heavily.  It is implemented in bash and in busybox
>>>> ash, but not, for example, in dash, and it is not
>>>> in POSIX either.
>>>>
>>>> So when the system /bin/sh does not implement this
>>>> construct, los of tests fails like this:
>>>
>>>
>>> Actually there are just 2 places which are trivial to fix,
>>> and the following patch does just that.
>>
>>
>> Actually there are more of these, and the original patch
>> was wrong.  Applied is another version which actually
>> works (and tested) and fixes more places, together with
>> $((n++) and `type -p'.
>
>
> Attached, not applied.  Actually attached now :)
>
>
>> With these changes, I can now run the testsuite on default
>> debian install.
>>
>> Thanks,

LGTM, applied.
thanks,


More information about the busybox mailing list