[git commit] hostid: do not output sign-extended host id. Closes 6056

[Thierry Reding]

On Mon, Mar 04, 2013 at 03:04:38AM +0100, Denys Vlasenko wrote:
> commit: http://git.busybox.net/busybox/commit/?id=9bbf6b98c42a212b8a4b1aa02975ac18bb612922
> branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master
> 
> Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
> ---
>  coreutils/hostid.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/coreutils/hostid.c b/coreutils/hostid.c
> index 5c1a4e0..e5b1f51 100644
> --- a/coreutils/hostid.c
> +++ b/coreutils/hostid.c
> @@ -36,7 +36,8 @@ int hostid_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM)
>  		bb_show_usage();
>  	}
>  
> -	printf("%08lx\n", gethostid());
> +	/* POSIX says gethostid returns a "32-bit identifier" */
> +	printf("%08x\n", (unsigned)(uint32_t)gethostid());

That's a bit over the top. uint32_t is already unsigned.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20130306/ea8b7661/attachment.asc>