AW: [PATCH] ubimkvol: add -m option to create volume of maximum size
Paul B. Henson
henson at acm.org
Thu Jun 20 00:43:39 UTC 2013
On Wed, Jun 19, 2013 at 11:31:28PM +0200, Bernhard Reutner-Fischer wrote:
> xstrtou() is equally well readable.
> Just compare the size(1) of both variants and pick the smaller (and show
> dietmar the numbers).
Per the busybox FAQ:
$ make bloatcheck
function old new delta
ubi_tools_main 1087 1130 +43
.rodata 149418 149413 -5
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 43/-5) Total: 38 bytes
text data bss dec hex filename
827227 4130 9552 840909 cd4cd busybox_old
827265 4130 9552 840947 cd4f3 busybox_unstripped
The patch converting the existing sscanf to xstrtou was a net increase of 38
bytes. I don't know if Mike's goal though was that he thought it would be
smaller, or he just wanted it to match other busybox code conventions.
I don't really care either way, I'd just like to get these features
included so I don't have to maintain them separately and they're available
to anybody else that might find them useful.
More information about the busybox
mailing list