[PATCH] ubi_tools: enhance -s option to allow size multiplier to match mtd-utils

Paul B. Henson henson at acm.org
Mon Jun 3 19:32:30 UTC 2013


On 6/3/2013 12:24 PM, Tito wrote:

> opts = getopt32(argv, "s:", &size_str);

The -s option is marked as requiring an argument:

opts = getopt32(argv, "md:n:N:s:a:t::",

> if (opts & OPT_S)
> 	 size_bytes = xstrtou_sfx(size_str, 10, size_suffixes);

I'm not completely clear on what you're getting at; I think what you're 
saying is that

    bb_error_msg_and_die("%s size not specified", "UBI");

is not required, as getopt32 would not allow you to specify -s without 
an argument.

However, as previously mentioned, potentially you could simply not 
supply -s at all. Or you could supply -m instead of -s.

So, if you don't supply -m, and you don't supply -s, it dies complaining 
about that.



More information about the busybox mailing list