Fixing unicode detection

Rich Felker dalias at aerifal.cx
Sun Jul 7 15:48:37 UTC 2013


On Sun, Jul 07, 2013 at 02:44:21PM +0200, Denys Vlasenko wrote:
> On Saturday 06 July 2013 07:20, Rich Felker wrote:
> > On Fri, Jul 05, 2013 at 10:01:38PM +0200, Denys Vlasenko wrote:
> > > On Wednesday 03 July 2013 08:35, Bernhard Reutner-Fischer wrote:
> > > > On 2 July 2013 17:47:51 Harald Becker <ralda at gmx.de> wrote:
> > > > > Hi Denys !
> > > > >
> > > > > >What are the chances that someone doesn't set $LANG, $LC_ALL,
> > > > > >but does set $LC_CTYPE?
> > > > >
> > > > > That's me ... I set all LC_ constants except LC_ALL. I need to
> > > > > set them separate as LC_ALL overwrite all and I only want German
> > > > > Locale (Numbers, style, etc.) but English text. Checking only for
> > > > > LC_ALL without checking for LC_CTYPE will break all my setups.
> > > > 
> > > > I am in the very same position.
> > > 
> > > Okay.
> > > I added $LC_CTYPE check.
> > 
> > Can you please also fix the fallback in reinit_unicode:
> > 
> > -	setlocale(LC_ALL, (LANG && LANG[0]) ? LANG : "C");
> > +	setlocale(LC_ALL, (LANG && LANG[0]) ? LANG : "");
> > 
> > This is necessary to solve the second case I care about (actually the
> > most important one to musl users) in my previous email.
> 
> Done.

Thank you!

Rich


More information about the busybox mailing list