[PATCH] do not use gethostbyname() for hostname -s

Denys Vlasenko vda.linux at googlemail.com
Tue Dec 17 18:14:41 UTC 2013


On Monday 09 December 2013 18:56, Michael Tokarev wrote:
> There's no reason to call gethostbyname() on the value returned
> by uname() when asked just for a short name of a host.  This may
> also be wrong, when uname is set to one value, but in /etc/hosts
> (or elsewhere) the "canonical" name is different.  This is often
> the case for localhost entry in /etc/hosts:
> 
>   127.0.0.1	localhost	myname
> 
> With this content of /etc/hosts, and uname being set to myname,
> busybox hostname -s will return localhost, while regular
> hostname utility returns myname.
> 
> Fix this by not calling gethostbyname() for the simple `hostname -s'
> use.
> 
> Signed-off-by: Michael Tokarev <mjt at tls.msk.ru>

Applied, thanks!


More information about the busybox mailing list