[PATCH busybox] networking: fix potential overflow in ife_print6()

Nicolas Dichtel nicolas.dichtel at 6wind.com
Mon Aug 12 15:09:59 UTC 2013


devname is used by fscanf to store a string specified by '%20s'.

Extract from the man for the '%s' specifier:
Matches a sequence of non-white-space characters; the next pointer must be a
pointer to character array that is long enough to hold the input sequence and
the terminating null byte ('\0'), which is added automatically. The input
string stops at white space or at the maximum field width, whichever occurs
first.

Hence, the right length is 20 + 1 for the '\0'.

Signed-off-by: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
---
 networking/interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/interface.c b/networking/interface.c
index 3dc5b3640b24..bf7d2b1b44ab 100644
--- a/networking/interface.c
+++ b/networking/interface.c
@@ -874,7 +874,7 @@ static void print_bytes_scaled(unsigned long long ull, const char *end)
 static void ife_print6(struct interface *ptr)
 {
 	FILE *f;
-	char addr6[40], devname[20];
+	char addr6[40], devname[21];
 	struct sockaddr_in6 sap;
 	int plen, scope, dad_status, if_idx;
 	char addr6p[8][5];
-- 
1.8.2.1



More information about the busybox mailing list