[vamos-dev] [PATCH 1/3] fix literal error warning

Manuel Zerpies manuel.f.zerpies at ww.stud.uni-erlangen.de
Tue Sep 18 11:51:21 UTC 2012


Hej guys,

> []
> >>>> -            bb_perror_msg(filename);
> >>>> +            bb_perror_msg("%s", filename);
> >> Please stop fixing a non-issue.  This GCC warning is wrong.
> >> This has been discussed several times, and exactly the same
> >> patch has been proposed several times too.
> > 
> > Actually, that half of his patch *is* legitimate.  It's a bug.
> > 
> 
> Oh. Yeah. there's one place which were identified in one of
> the previous patches which tried to address this problem.
> 
> Please excuse me for not looking close enough and for making
> premature and harsh comments.  I was very angry this morning
> due to unrelated issues, I shouldn't reply to emails in that
> bad mood.
> 
> I stand corrected.  And indeed, this patch looks right.

okay. If this part is legitimate, shall I send in a patch with only
this half of the patch to be accepted, or is the other half of the
patch "okay" too, so that this patch can be accepted as it is?

Greets,
Manuel


More information about the busybox mailing list