[PATCH] udhcpc: gracefully handle packets with CHECKSUM_PARTIAL

[Denys Vlasenko]

On Tue, Sep 11, 2012 at 11:41 AM, Alexey I. Froloff <raorn at raorn.name> wrote:
> On Fri, Sep 07, 2012 at 12:50:08PM +0400, Alexey I. Froloff wrote:
>> When running as KVM or Xen guest, packets may be received with
>> incomplete checksum[1].  Patch adapted from Fedora dhcp package.
>>
>> [1]. http://article.gmane.org/gmane.linux.kernel/1003853
>
> So, what about this patch?  Similar fixes for other DHCP clients
> exists for about five years...

I try to make it smaller (See attached), but it still
seems to be costly size-wise:

function                                             old     new   delta
udhcp_recv_raw_packet                                415     579    +164
change_listen_mode                                   317     370     +53

Can VM's disable checksumming not wholesale, but on
per-port basis? DHCP packets are such a tiny minority
of the typical traffic it's not worth saving nanoseconds on them.

-- 
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: application/octet-stream
Size: 3406 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20120917/e0dd0121/attachment.obj>