[vamos-dev] [PATCH 1/3] fix literal error warning

[Michael Conrad]

On 9/10/2012 11:46 AM, Michael Tokarev wrote:
> On 10.09.2012 19:31, Manuel Zerpies wrote:
>> Hey guys,
>>
>> what about this patch? Is there anyone who can have a look at it?
>>
> []
>>> -			bb_perror_msg(filename);
>>> +			bb_perror_msg("%s", filename);
> Please stop fixing a non-issue.  This GCC warning is wrong.
> This has been discussed several times, and exactly the same
> patch has been proposed several times too.

Actually, that half of his patch *is* legitimate.  It's a bug.

   $ ./busybox stat -f "%s"
   stat: (null): No such file or directory

It's only on the SELINUX enabled binary.

Here's the full context:

#if ENABLE_SELINUX
         security_context_t scontext = NULL;

         if (option_mask32 & OPT_SELINUX) {
                 if ((option_mask32 & OPT_DEREFERENCE
                      ? lgetfilecon(filename, &scontext)
                      : getfilecon(filename, &scontext)
                     ) < 0
                 ) {
                         bb_perror_msg(filename);
                         return 0;
                 }
         }
#endif
         if (statfs(filename, &statfsbuf) != 0) {
                 bb_perror_msg("can't read file system information for 
'%s'", filename);
                 return 0;
         }