repost: [PATCH] add -q option to sysctl applet

Joshua Kahlenberg jbkberg at gmail.com
Tue Sep 4 13:36:50 UTC 2012


On Tue, 04 Sep 2012 03:13:38 -0500, Denys Vlasenko
<vda.linux at googlemail.com> wrote:

> On Sun, Sep 2, 2012 at 7:42 PM, Joshua Kahlenberg <jbkberg at gmail.com>  
> wrote:
>> Sorry, previous patch was wrapped
>
> And this version is mangled too:
>
>> Content-Type: text/plain; charset="us-ascii"; Format="flowed";  
>> DelSp="yes"
>
> Flowed format causes all kinds of PITA.
>
> Please resend as attachment.
>
>>  //usage:       "sysctl [-n] [-e] -A\n"
>> +//usage:       "sysctl [-n] [-e] -q\n"
>
> No, -q is not used like this. Add "[-q]"
> to those lines where it makes sense.
>
>> +               if (!(option_mask32 & FLAG_QUIET))
>>                 puts(value);
>
> puts() should get one additional tab of indentation.
>

Here is the patch as an attachment with the above changes.

-- 
jbkberg (AT) gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-add-q-option-to-sysctl.patch
Type: application/octet-stream
Size: 1774 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20120904/a16aa436/attachment.obj>


More information about the busybox mailing list