Fwd: Re: [PATCH] v5 mktemp: make -u option work more like coreutils

Denys Vlasenko vda.linux at googlemail.com
Mon Oct 8 09:50:09 UTC 2012


On Wednesday 03 October 2012 14:38, Tito wrote:
> Hi Denys,
> maybe this patch slipped through?

Applying!

> -	/* -q is ignored */
> -	opt_complementary = "?1"; /* 1 argument max */
> +	/* -p implies -t */
> +	opt_complementary = "?1:pt"; /* 1 argument max */

Addition of ":pt" seem to be unnecessary: code always checks
opts & (OPT_t|OPT_p).

> +	/* Don't allow directory separator in template */
> +	if ((opts & OPT_t) && bb_basename(chp) != chp) {
> +		errno = EINVAL;
> +		goto error;
>  	}

Why? Can't we just allow this to work?

Applied sans these two details. Thanks!
-- 
vda


More information about the busybox mailing list