[Patch]: comment defines

walter harms wharms at bfs.de
Mon Jun 18 23:14:56 UTC 2012



Am 19.06.2012 00:21, schrieb Denys Vlasenko:
> On Monday 18 June 2012 21:24, walter harms wrote:
>> The code contains two undocumented defines
>> add short description for these.
>>
>> Signed-off-by: wharms <wharms at bfs.de>
>> ---
>>
>> --- ftpd.c.org	2012-06-17 23:23:25.000000000 +0200
>> +++ ftpd.c	2012-06-17 23:24:09.000000000 +0200
>> @@ -28,6 +28,11 @@
>>  //usage:     "\n	-t,-T	Idle and absolute timeouts"
>>  //usage:     "\n	DIR	Change root to this directory"
>>
>> +/*
>> + IF_WE_WANT_TO_REQUIRE_LOGIN         - Enable login
>> + WHY_BOTHER_WE_CAN_ASSUME_IP_MATCHES - verify that PORT's IP matches getpeername().
>> +*/
> 
> I hoped their names are already descriptive...
> 

hi Denis
The idea was to place them in start of the file. So people looking for special options know
what they can do. I have encounters options that linger in files for ages and people were not
aware of it.

re,
 wh


More information about the busybox mailing list