[PATCH 2/2] modprobe-small: allow blacklist for compatibility

Denys Vlasenko vda.linux at googlemail.com
Tue Jan 31 13:46:36 UTC 2012


On Fri, Jan 20, 2012 at 12:07 AM, Felipe Contreras
<felipe.contreras at gmail.com> wrote:
> Signed-off-by: Felipe Contreras <felipe.contreras at gmail.com>
> ---
>  modutils/modprobe-small.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/modutils/modprobe-small.c b/modutils/modprobe-small.c
> index f5b283b..2b1b6c5 100644
> --- a/modutils/modprobe-small.c
> +++ b/modutils/modprobe-small.c
> @@ -805,7 +805,7 @@ int modprobe_main(int argc UNUSED_PARAM, char **argv)
>        opt_complementary = "-1";
>        /* only -q (quiet) and -r (rmmod),
>         * the rest are accepted and ignored (compat) */
> -       getopt32(argv, "qrfsvw");
> +       getopt32(argv, "bqrfsvw");
>        argv += optind;

This is wrong. Comment just before this code even tried to prevent
this kind of bug: it says that -q and -r are used.

Check OPT_q and OPT_r constants in this file.

-- 
vda


More information about the busybox mailing list