small patch to fix android ndk build of busybox

Denys Vlasenko vda.linux at googlemail.com
Sun Jan 8 15:15:28 UTC 2012


On Saturday 07 January 2012 17:55, Hin-Tak Leung wrote:
> > How about this fix?
> > 
> > http://git.busybox.net/busybox/commit/?id=6b64a269766ace40c56826738de446537add37de
> > 
> 
> 
> No, cannot be a macro. Probably need a proper no-op function?
> 
> ====================================
> $ make
>   SPLIT   include/autoconf.h -> include/config/*
>   GEN     include/bbconfigopts.h
>   HOSTCC  applets/usage
>   GEN     include/usage_compressed.h
>   HOSTCC  applets/applet_tables
>   GEN     include/applet_tables.h
>   CC      applets/applets.o
> In file included from include/libbb.h:83,
>                  from include/busybox.h:8,
>                  from applets/applets.c:9:
> ../sysroot/usr/include/pwd.h:116:19: error: macro "endpwent" passed 1 arguments, but takes just 0
> ==========================
> 
> The android system header prototypes it as 
> 
> "void endpwent(void);"
> 
> That seems to suggest that endpwent() exists in bionic. The same header has
> "setpwent(void);" defined out and removed with a comment "#if 0 /* MISSING FROM BIONIC */".
> 
> So either it is a bug with android's header, or it needs to be a proper no-op function?

No-op func would probably work, another solution is to move defines
after includes of pwd.h and grp.h. I did this. Please test
current git.

-- 
vda


More information about the busybox mailing list