[PATCH] implement find -ipath

Denys Vlasenko vda.linux at googlemail.com
Sun May 22 02:35:11 UTC 2011


On Sunday 22 May 2011 04:07, Rich Felker wrote:
> On Sun, May 22, 2011 at 03:51:01AM +0200, Denys Vlasenko wrote:
> > > -	return fnmatch(ap->pattern, fileName, 0) == 0;
> > > +	return fnmatch(ap->pattern, fileName, (ap->ipath ? FNM_CASEFOLD : 0)) == 0;
> 
> FNM_CASEFOLD is a nonportable GNU feature. This should be made
> optional, as this patch seems to break building busybox find against
> musl.
> 
> Also, note that it's nearly impossible to implement case folding
> fnmatch without just implementing fnmatch in terms of regex, due to
> the complexity of Unicode case folding, so we have very good reason
> for not supporting this nonstandard extension in musl...

You don't have to implement Unicode case folding. ASCII will be enough
for 99.9% of users.

-- 
vda


More information about the busybox mailing list