all these warnings...

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Wed May 18 16:27:14 UTC 2011


On Mon, 16 May 2011, Cristian Ionescu-Idbohrn wrote:
> On Mon, 16 May 2011, Denys Vlasenko wrote:
> > On Saturday 07 May 2011 16:48, Cristian Ionescu-Idbohrn wrote:
> > > On Sun, 1 May 2011, Denys Vlasenko wrote:
> > > > On Sunday 01 May 2011 10:38, Cristian Ionescu-Idbohrn wrote:
> > > > > On Sat, 30 Apr 2011, Denys Vlasenko wrote:
> > > > > > On Saturday 30 April 2011 18:34, Cristian Ionescu-Idbohrn wrote:
> > > > > > > dist: debian unstable (aka sid)
> > > > > > > gcc-4.6.real (Debian 4.6.0-6) 4.6.1 20110428 (prerelease)
> > > > > > > BusyBox v1.19.0.git (2011-04-30 18:22:26 CEST) multi-call binary.
> > > > > > >
> > > > > > > I'd like to understand what's going on, why, and what I can do about it:
> > > > > > >
> > > > > > >   HOSTCC  scripts/kconfig/conf.o
> > > > > > > scripts/kconfig/conf.c: In function 'conf_string':
> > > > > > > scripts/kconfig/conf.c:176:20: warning: variable 'help' set but not used
> > > > > > > [-Wunused-but-set-variable]
> > > > > >
> > > > > > Above, variable "help" is not used and can be deleted.
> > > > > > You can send a patch which fixes it.
> > > > >
> > > > > Alright.  See attached patch proposals.
> > > > > 3 + 2 + 1 warnings may now be gone, half a gazillion still lurking around ;)
> > > >
> > > > Applied, thanks
> > >
> > > Along the same lines, see attached patch proposals.
> >
> > Applied, thanks
>
> Thanks.  I still find some of those things after todays git pull:

Let me try again.  The attached patch removes these warnings:

> archival/dpkg.c: In function 'set_status':
> archival/dpkg.c:712:6: warning: variable 'status_len' set but not used [-Wunused-but-set-variable]
> archival/dpkg.c:711:6: warning: variable 'flag_len' set but not used [-Wunused-but-set-variable]
> archival/dpkg.c:710:6: warning: variable 'want_len' set but not used [-Wunused-but-set-variable]

but not these:

> debianutils/run_parts.c: In function 'run_parts_main':
> debianutils/run_parts.c:158:6: warning: array subscript is above array bounds [-Warray-bounds]

One warning:

> libbb/appletlib.c: In function 'check_suid':
> libbb/appletlib.c:566:2: warning: label 'ret' defined but not used [-Wunused-label]

removed (see attached), two left to go:

> libbb/appletlib.c: In function 'busybox_main':
> libbb/appletlib.c:698:7: warning: variable 'use_symbolic_links' set but not used [-Wunused-but-set-variable]
> libbb/appletlib.c: In function 'main':
> libbb/appletlib.c:791:2: warning: implicit declaration of function '__sysconf' [-Wimplicit-function-declaration]
>
> but I believe my previous patch proposals covered the archival/dpkg.c one.


Cheers,

-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: -Wunused-but-set-variable.03.patch
Type: text/x-diff
Size: 2367 bytes
Desc: 
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20110518/ea3744a8/attachment.bin>


More information about the busybox mailing list