[PATCH] portmap: new applet

Rich Felker dalias at aerifal.cx
Sun May 1 22:13:34 UTC 2011


On Sun, May 01, 2011 at 07:38:27PM +0200, Marek Polacek wrote:
> > +int portmap_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
> > +int portmap_main(int argc, char **argv)
> > +{
> > +	char *host = (char *)"0.0.0.0";
> 

This cast is a no-op. 

> This doesn't seem right.  I think the `host' should be const char *, since
> the `create_and_bind_{stream,dgram}_or_die' expect const char *.

Passing char * where const char * is expected is perfectly valid.

Rich


More information about the busybox mailing list