[PATCHv3] HISTFILESIZE environment variable support in ash and hush
Alexey Fomenko
ext-alexey.fomenko at nokia.com
Thu Mar 31 07:21:07 UTC 2011
On Sun, 2011-03-27 at 02:05 +0100, ext Denys Vlasenko wrote:
> I don't see potential "char *history[100000];" as a good thing.
Decreased to 999
>
> In general, interrelation between ash and lineedit you are introducing
> is wrong. Can you simply add a new member, unsigned hist_max_size,
> to line_input_t structure, and fill it in ash from $MAXHISTSIZE,
> instead of using lookupvar_histfilesize()?
Yep, this looks better indeed.
>
> Please don't include debian-specific parts in the patch,
> they cause errors on apply.
Ok, sorry.
> Patch still contains trailing whitespace.
Fixed in new version (in attachment)
-------------------------------------------------------------------------------
Add support of HISTFILESIZE env var in ash and hush
include/libbb.h | 8 +++++++
libbb/Config.src | 9 +++++++
libbb/lineedit.c | 32 +++++++++++++++------------
shell/ash.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
shell/hush.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 151 insertions(+), 14 deletions(-)
--
1.7.3.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-support-of-HISTFILESIZE-env-var-in-ash-and-hush.patch
Type: text/x-patch
Size: 9766 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20110331/fa4f2a82/attachment.bin>
More information about the busybox
mailing list