[PATCH 1/3] removed dead code. pargv was set NULL before cycle manually

Denys Vlasenko vda.linux at googlemail.com
Tue Mar 1 18:38:57 UTC 2011


On Tuesday 01 March 2011 12:38, Alexey Fomenko wrote:
> Manually setting pargv = NULL gives dead code. Looks like it's unused
> anyway. 
> 
> Signed-off-by: Alexey Fomenko <ext-alexey.fomenko at nokia.com>
> ---
>  libbb/getopt32.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/libbb/getopt32.c b/libbb/getopt32.c
> index 25bae31..576d52f 100644
> --- a/libbb/getopt32.c
> +++ b/libbb/getopt32.c
> @@ -542,8 +542,6 @@ getopt32(char **argv, const char *applet_opts, ...)
>  #endif
>  	/* optarg = NULL; opterr = 0; optopt = 0; - do we need this?? */
>  
> -	pargv = NULL;
> -
>  	/* Note: just "getopt() <= 0" will not work well for
>  	 * "fake" short options, like this one:
>  	 * wget $'-\203' "Test: test" http://kernel.org/
> @@ -585,8 +583,6 @@ getopt32(char **argv, const char *applet_opts, ...)
>  			if (optarg)
>  				*(char **)(on_off->optarg) = optarg;
>  		}
> -		if (pargv != NULL)
> -			break;
>  	}
>  
>  	/* check depending requires for given options */

Applied, thanks!
-- 
vda


More information about the busybox mailing list