[PATCH 2/2] rmmod (modprobe-small): display error on nonexistent module

Federico Vaga federico.vaga at gmail.com
Wed Jun 29 15:41:57 UTC 2011


No error is displayed when you try to unload a nonexistent module; only if
debug mode is active a message is showed. It can be a problem because on
missed typeing error busybox do not return error and it might be thought that
the real module is removed, but it not and it might be a problem.

Signed-off-by: Federico Vaga <federico.vaga at gmail.com>
---
 modutils/modprobe-small.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modutils/modprobe-small.c b/modutils/modprobe-small.c
index 57b83c0..e7c241a 100644
--- a/modutils/modprobe-small.c
+++ b/modutils/modprobe-small.c
@@ -532,7 +532,7 @@ static void process_module(char *name, const char *cmdline_options)
 
 	dbg1_error_msg("already_loaded:%d is_rmmod:%d", already_loaded(name), is_rmmod);
 	if (already_loaded(name) != is_rmmod) {
-		dbg1_error_msg("nothing to do for '%s'", name);
+		bb_error_msg("nothing to do for '%s'", name);
 		return;
 	}
 
-- 
1.7.5.4



More information about the busybox mailing list