[PATCH 4/5] Gate including net/ethernet.h on HAVE_NET_ETHERNET_H

Denys Vlasenko vda.linux at googlemail.com
Fri Jun 3 18:45:21 UTC 2011


On Thursday 02 June 2011 01:27, Rich Felker wrote:
> On Wed, Jun 01, 2011 at 01:36:20PM -0700, Dan Fandrich wrote:
> > +#if defined(__GLIBC__) && (__GLIBC__ < 2 || __GLIBC_MINOR__ < 1)
> > +# undef HAVE_NET_ETHERNET_H
> > +#endif
> 
> This is nonsense. glibc older than 2.1 is definitely not usable.
> 
> > -#if (defined(__GLIBC__) && __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 1) || defined(_NEWLIB_VERSION)
> > +#ifdef HAVE_NET_ETHERNET_H
> >  # include <netpacket/packet.h>
> >  # include <net/ethernet.h>
> >  #else
> 
> I suspect this might break support for anything that lacks
> netpacket/packet.h, including musl.

Why musl has no netpacket/packet.h? Are you going to convince every single
project which includes it to work around its absense?

Google code search says you have 630 projects to go.

-- 
vda


More information about the busybox mailing list