[PATCH 4/5] Gate including net/ethernet.h on HAVE_NET_ETHERNET_H

[Rich Felker]

On Wed, Jun 01, 2011 at 11:17:16PM -0700, Dan Fandrich wrote:
> > I suspect this might break support for anything that lacks
> > netpacket/packet.h, including musl. In general it's a very bad idea to
> > use the same HAVE_* macro for two completely separate headers.
> 
> In general, yes, but net/ethernet.h & netpacket/packet.h seem to go hand
> in hand in many places in Busybox. The presence or absence of
> net/ethernet.h is taken as a signal to use one of two methods of getting
> the correct Ethernet definitions. It could be made more complicated with
> many more HAVE_ macros, but I'll leave it to someone who has a need for that
> to make that change.

Well the issue is that I believe you're breaking one (admittedly
minority, at present) system for the sake of supporting another. This
is hardly progress...

Rich