typo in id.c?

Tito farmatito at tiscali.it
Wed Jan 26 14:47:33 UTC 2011


On Wednesday 26 January 2011 15:24:17 Gilles Espinasse wrote:
> Selon Tito <farmatito at tiscali.it>:
> 
> > Hi,
> > in id.c maybe I've found a minor bug.
> >
> > 		} else if (n < 0) { /* error in get_groups() */
> > -			if (!ENABLE_DESKTOP)
> > +			if (ENABLE_DESKTOP)
> > 				bb_error_msg_and_die("can't get groups");
> > 			else
> > 				return EXIT_FAILURE;
> > 		}
> >
> >
> > ciao,
> > Tito
> 
> 
> Another issue.
> 
> Should really 'return EXIT_FAILURE' depend of ENABLE_DESKTOP?
> 
> 
> Gilles
> 

My idea was ENABLE_DESKTOP = bloat so verbose error message
                   !ENABLE_DESKTOP= minimal so only return error to shell

Maybe I'm overlooking something obvious?
Ciao,
Tito 



More information about the busybox mailing list