about gcc warnings

[gotrunks at gmail.com]

On Sun, Feb 13, 2011 at 6:31 PM, Denys Vlasenko
<vda.linux at googlemail.com> wrote:
> On Sunday 13 February 2011 14:24, Gilles Espinasse wrote:
>>
>> ----- Original Message -----
>> From: <gotrunks at gmail.com>
>> To: <busybox at busybox.net>
>> Sent: Sunday, February 13, 2011 1:39 PM
>> Subject: about gcc warnings
>>
>>
>> > In busybox there are a lot of compile warnings like:
>> > networking/wget.c:365: warning: format not a string literal and no
>> > format arguments
>> >
>> > are these warnings wanted for some reason?
>
> I don't get any such warnings.
>

maybe it's my configuration, but I'm using the default values of 'make
menuconfig'

>> Should only be rusting code
>> This sort of warning is not present in 1.17.3.
>>
>> > or can I fix them, like in the example below?
>> >
>>
>>
>> > -               bb_perror_msg_and_die(bb_msg_memory_exhausted);
>> > +               bb_perror_msg_and_die("%s", bb_msg_memory_exhausted);
>>
>> To my understanding, this is the right fix.
>
> But this just increases code size for no benefit.
>

Ok.

> --
> vda
>