[PATCHv3] httpd: don't drop/abuse QUERY_STRING when /cgi-bin/index.cgi is used
Denys Vlasenko
vda.linux at googlemail.com
Tue Dec 20 01:00:15 UTC 2011
On Monday 19 December 2011 12:54, Peter Korsgaard wrote:
> >>>>> "Denys" == Denys Vlasenko <vda.linux at googlemail.com> writes:
>
> Hi,
>
> >> The memory pointed to by g_query gets overwritten when the index_page
> >> is used, causing URL arguments to get dropped when we fall back to
> >> /cgi-bin/index.cgi. QUERY_STRING if furthermore hijacked to pass the
> >> original (<DIR>/) URI to the CGI script, which is quite non-standard
> >> and disallows use of URL arguments.
> >>
> >> Fix it by instead passing the original URI in REQUEST_URI, and make a
> >> deep copy of the URL arguments before they get overwritten, if needed.
> >>
> >> Also update httpd_indexcgi to take the directory location from
> >> REQUEST_URI instead.
>
> Denys> Applied, thanks!
>
> Thanks. Any reason why you dropped most of my commit message?
It was just an oversight on my part. Sorry.
> Don't you use 'git am -s' to apply it?
No, I applied it by hand.
--
vda
More information about the busybox
mailing list