[PATCH RESEND] cttyhack: remove the trailing newline when reading console name from sysfs

Kevin Cernekee cernekee at gmail.com
Sun Aug 14 20:55:11 UTC 2011


The current version of cttyhack does not properly truncate the newline
at the end of the string read from /sys/class/tty/console/active .
Prior discussion here:

http://lists.busybox.net/pipermail/busybox/2011-July/thread.html#76139
http://lists.busybox.net/pipermail/busybox/2011-July/076276.html

I have verified that the problem impacts v1.19.0.

Bloat-o-meter:

function                                             old     new   delta
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0)                 Total: 0 bytes
   text    data     bss     dec     hex filename
 478349    1338    4441  484128   76320 busybox_old
 478349    1338    4441  484128   76320 busybox_unstripped

I am also attaching a (new) spelling/whitespace fix, for the same file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cttyhack-remove-the-trailing-newline-when-reading-co.patch
Type: application/octet-stream
Size: 1049 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20110814/89cb6a64/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-cttyhack-trivial-spelling-spacing-fixes.patch
Type: application/octet-stream
Size: 1447 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20110814/89cb6a64/attachment-0001.obj>


More information about the busybox mailing list