all these warnings...

Harald Becker ralda at gmx.de
Sat Apr 30 20:49:52 UTC 2011


 Hallo Denys!

>                         /* print help */
>                         if (line[1] == '\n') {
>                                 help = nohelp_text;
>                                 if (menu->sym->help)
>                                         help = menu->sym->help;
>                                 printf("\n%s\n", menu->sym->help);
>                                 def = NULL;
>                                 break;
> Above, variable "help" is not used and can be deleted.

Shouldn't this be ... ?

printf( "\n%s\n", help );

or may be better ... ?

printf("\n%s\n", menu->sym->help ? menu->sym->help : nohelp_text );

--
Harald



More information about the busybox mailing list