GNU-ism in sed use in build scripts

Denys Vlasenko vda.linux at googlemail.com
Sat Apr 16 16:00:49 UTC 2011


On Friday 15 April 2011 20:17, Chris Rees wrote:
> Hi,
> 
> Is it vital that 'sed --' is used in scripts/gen-build-files.sh?
> 
> It uses the variable $srcdir, which is set in the Makefile to an
> absolute path; although of course it would normally be sensible to use
> -- when using a variable.
> 
> Unfortunately this causes non-GNU sed to break on scripts/gen-build-files.sh.
> 
> I've got around it so far by using GNU sed, but it'd be great to
> remove that dependency from my point of view.
> 
> Would the patch at [1] be acceptable?

It makes sense to explain the reason in a comment.

Applied.
-- 
vda


More information about the busybox mailing list