[PATCH] size reduction and better error reporting for deluser/delgroup

Tito farmatito at tiscali.it
Sun Sep 26 22:45:26 UTC 2010


On Monday 27 September 2010 00:33:02 Tito wrote:
> 

Hi
the patch previously sent reduces the size of the deluser/delgroup commands.
Size reduction with all options enabled is:

scripts/bloat-o-meter busybox_old busybox_unstripped
function                                             old     new   delta
deluser_main                                         189     155     -34
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-34)             Total: -34 bytes

The patch is compile-tested with all options enabled/disabled
and is tested for  functionality.
The patched version has all features of the current version
plus better error reporting when user/group doesn't exist,
More testing  and review from the list members is welcome.
Hints about how to reduce size further are welcome.

TODO & CAVEAT:
	1) we don't warn about removing user's primary group when doing delgroup
        2) we don't remove users primary group when doing deluser
        3) -h --help are treated as user/group names

Is there any interest in this features?

Ciao,
Tito

P.S.: sorry for double posting, but somehow the message text in the previous email vanished...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deluser.c
Type: text/x-csrc
Size: 1522 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20100927/269e603a/attachment-0001.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deluser_02.patch
Type: text/x-diff
Size: 2227 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20100927/269e603a/attachment-0001.bin>


More information about the busybox mailing list