Build doesn't fail if od not installed

walter harms wharms at bfs.de
Thu Sep 16 12:20:38 UTC 2010



There is a list of commands in  Filesystem Hierarchy Standard (p.5).
Obviously  we expect more like a c-compiler but there is no need to
test anything that is no in that list.

The required tests can be done in a special file that can be executed by
the user and returns something like "you can no compiled bb because ...".

NTL the main problem here is that the missing "od" is detected but the script
is continuing only to fail otherwise.

re,
 wh


Denys Vlasenko schrieb:
> On Thu, Sep 16, 2010 at 10:58 AM, Harald Becker <ralda at gmx.de> wrote:
>>  Hi!
>>
>> I just had some really big trouble because of busybox build not failing
>> if od is not installed. The build throws a message about this but
>> otherwise it continues. As this goes that fast I didn't mention this
>> message and assumed those messages are only warnings ... but missing od
>> leads into trouble preparing the usage messages which gives a
>> segmentation fault as soon as you try to invoke "busybox APPLETNAME
>> --help" ... needed hours to find the reason for this!
>>
>> Denys, can you fix this, so that a missing required program leads into a
>> build abort? Thx!
> 
> Yes, can do. See attachment.
> 
> But where should we stop?
> 
> od is part of the coreutils. The key part here is "core".
> 
> Should I also make build fail if dd is not available? Or sed? Or grep?
> Or cp? mv? rm? cat? mkdir?
> 
> Can you imagine how ugly the scripts would look which check
> for every one of these programs?
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox


More information about the busybox mailing list