[busybox build error] libbb/md5.c: error: assignment of read-only location '*words'

[Douglas Mencken]

  CC      libbb/md5.o
  CC      libbb/messag

Yeah, it does :)
It's exactly what I tried after discovering the error.
Well, if being const here is not really important (or even useless),
then such patch is okay.

On Sun, Oct 17, 2010 at 11:00 PM, Denys Vlasenko
<vda.linux at googlemail.com> wrote:
> On Sunday 17 October 2010 20:24, Douglas Mencken wrote:
>>   CC      libbb/md5.o
>> libbb/md5.c: In function 'md5_process_block64':
>> libbb/md5.c:233:2: error: assignment of read-only location '*words'
>> libbb/md5.c:234:2: error: assignment of read-only location '*words'
>> libbb/md5.c:235:2: error: assignment of read-only location '*words'
>> libbb/md5.c:236:2: error: assignment of read-only location '*words'
>> libbb/md5.c:237:2: error: assignment of read-only location '*words'
>> libbb/md5.c:238:2: error: assignment of read-only location '*words'
>> libbb/md5.c:239:2: error: assignment of read-only location '*words'
>> libbb/md5.c:240:2: error: assignment of read-only location '*words'
>> libbb/md5.c:241:2: error: assignment of read-only location '*words'
>> libbb/md5.c:242:2: error: assignment of read-only location '*words'
>> libbb/md5.c:243:2: error: assignment of read-only location '*words'
>> libbb/md5.c:244:2: error: assignment of read-only location '*words'
>> libbb/md5.c:245:2: error: assignment of read-only location '*words'
>> libbb/md5.c:246:2: error: assignment of read-only location '*words'
>> libbb/md5.c:247:2: error: assignment of read-only location '*words'
>> libbb/md5.c:248:2: error: assignment of read-only location '*words'
>> make[1]: *** [libbb/md5.o] Error 1
>> make: *** [libbb] Error 2
>>
>> It is obviously caused by commit git show
>> cfe114c4f3d4e1dfc00196d8df316874eaf2d2b8.
>
> Does this fix it?
>
> diff -ad -urpN busybox.7/libbb/md5.c busybox.8/libbb/md5.c
> --- busybox.7/libbb/md5.c       2010-10-17 11:35:34.000000000 +0200
> +++ busybox.8/libbb/md5.c       2010-10-17 22:59:04.000000000 +0200
> @@ -87,7 +87,7 @@ static void md5_process_block64(md5_ctx_
>                0, 7, 14, 5, 12, 3, 10, 1, 8, 15, 6, 13, 4, 11, 2, 9    /* 4 */
>        };
>  #endif
> -       const uint32_t *words = (const void*) ctx->wbuffer;
> +       uint32_t *words = (void*) ctx->wbuffer;
>        uint32_t A = ctx->A;
>        uint32_t B = ctx->B;
>        uint32_t C = ctx->C;
>
>
>
> --
> vda
>