tab completion with special characters

Denys Vlasenko vda.linux at googlemail.com
Mon Nov 22 02:50:46 UTC 2010


On Thursday 18 November 2010 23:25, Mike Shal wrote:
> Hello,
> 
> Using ash in busybox git version dea28e1e, tab completion doesn't seem
> to work properly for filenames that have special characters (such as
> spaces) in them. For example, with filenames "foo bar" and "foo zap",
> typing "ls fo<TAB>" correctly expands to "ls foo\ ", but then
> continuing to type "b<TAB>" will produce "ls foo\ bbar", which is not
> correct (the 'b' is duplicated).
> 
> I bisected it down to commit 3c460b005, which made some changes to
> lineedit.c. It seems the complete_cmd_dir_file() function is not
> accounting for the backslashes that are inserted. The attached commit
> seems to fix the issue, though I'm not sure what 3c460b005 was trying
> to address so that probably needs to be re-checked.

Thanks! Applied in a slightly different form.
-- 
vda


More information about the busybox mailing list