[PATCH] gen_build_files.sh: rewrite with sed

Mike Frysinger vapier at gentoo.org
Wed Nov 17 23:37:15 UTC 2010


On Tuesday, November 16, 2010 16:06:05 Bernhard Reutner-Fischer wrote:
> On Tue, Nov 16, 2010 at 09:31:13PM +0100, Cristian Ionescu-Idbohrn wrote:
> >On Tue, 16 Nov 2010, Mike Frysinger wrote:
> >> The shell parsing of files is incredibly slow on many systems.  With
> >> one report, the process was taking a minute or two which made people
> >> thing the build was hung.  So rewrite the craziness with sed and proper
> >> shell functions.  On an idle system, this cut the runtime by half.
> >
> >Sounds good.  Still, you can surely explain the inconsistant and totally
> >superfluous curly brackets around variable names.
> 
> The whole shell thing is superfluous.

agreed, but i'm not interested in a larger debate/work.  i'll make the shell 
code not suck if you want to take a whole rewrite as a followup.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20101117/84e5c7cd/attachment.pgp>


More information about the busybox mailing list