[PATCH] gen_build_files.sh: Remove bashisms

[Cristian Ionescu-Idbohrn]

On Sat, 15 May 2010, Denys Vlasenko wrote:

> On Friday 14 May 2010 01:05, Peter Tyser wrote:
> > -find -type d | while read; do
> > -	d="$REPLY"
> > -
> > +find -type d | while read d; do
>
> I applied this part, and changed #!/bin/sh to bash.
>
> Thanks!

Thank you.

I had a look through and found:

,----[ individual ]
| possible bashism in individual line 15 (brace expansion):
| make busybox.links include/bb_config.h $(pwd)/{libbb/libbb.a,archival/libunarchive/libunarchive.a,coreutils/libcoreutils/libcoreutils.a,networking/libiproute/libiproute.a}
| possible bashism in individual line 31 ('function' is useless):
| function substithing()
| possible bashism in individual line 33 (${parm/?/pat[/str]}):
|   if [ "${1/ $3 //}" != "$1" ]
| possible bashism in individual line 39 ('function' is useless):
| function extra_libraries()
| possible bashism in individual line 70 ('function' is useless):
| function bonkname()
| possible bashism in individual line 74 (should be 'b = a'):
|     if [ "$APPLET" == "$1" ]
| possible bashism in individual line 76 (${parm/?/pat[/str]}):
|       APPFILT="${2/@*/}"
| possible bashism in individual line 77 (should be 'b = a'):
|       if [ "${APPFILT}" == "$2" ]
| possible bashism in individual line 81 (${parm/?/pat[/str]}):
|         HELPNAME="${2/*@/}"_full_usage
| possible bashism in individual line 92 ('function' is useless):
| function buildit ()
`----

,----[ mkdiff_obj ]
| possible bashism in mkdiff_obj line 5 ($'...' should be "$(printf '...')"):
|         sed $'s/^\\(\t*\\)[ ]*[0-9a-f][0-9a-f]*:[ \t]*/\\1/' \
`----

,----[ randomtest.loop ]
| possible bashism in randomtest.loop line 16 ($RANDOM):
|                 dir="test.$$.$RANDOM"
| possible bashism in randomtest.loop line 23 (let ...):
|                 let fail++
| possible bashism in randomtest.loop line 37 (let ...):
|         let cnt++
`----

,----[ trylink ]
| possible bashism in trylink line 49 ($RANDOM):
|     local tempname="/tmp/temp.$$.$RANDOM"
| possible bashism in trylink line 61 ($RANDOM):
|     local tempname="/tmp/temp.$$.$RANDOM"
`----

you might want to look into.


Cheers,

-- 
Cristian