[PATCH] gen_build_files.sh: Remove bashisms
Denys Vlasenko
vda.linux at googlemail.com
Sat May 15 15:07:37 UTC 2010
On Friday 14 May 2010 22:52, Cristian Ionescu-Idbohrn wrote:
> On Fri, 14 May 2010, Rob Landley wrote:
>
> > On Thursday 13 May 2010 18:05:53 Peter Tyser wrote:
> > > Using 'read' without a variable is not supported in many shells. Lines
> > > such as 'while read; do' in gen_build_files.sh would result in build
> > > failures when using sh or dash as an interpreter:
> >
> > Simple fix: say #!/bin/bash at the top of all shell scripts, always.
>
> Not surprisingly, I disagree :)
> dash is 5+ times faster than bash.
I think adding "bash compat" in read builtin in dash
wouldn't make it 5 times slower, while it will
avoid problems for a lot of people by not making
scripts break.
This assumes that dash developers are not on a crusade
to implement what standards say, and not an iota more.
--
vda
More information about the busybox
mailing list