Please stop screwing up loop.c

Rob Landley rob at landley.net
Mon Mar 15 22:00:44 UTC 2010


In current git:

git checkout -f && git clean -fdx && make defconfig && make 

  CC      libbb/loop.o
In file included from /usr/include/asm/types.h:4,
                 from /usr/include/linux/loop.h:27,
                 from libbb/loop.c:17:
/usr/include/asm-generic/int-ll64.h:27: error: conflicting types for 
‘bb_hack___s64’
include/fix_u32.h:38: error: previous declaration of ‘bb_hack___s64’ was here
/usr/include/asm-generic/int-ll64.h:28: error: conflicting types for 
‘bb_hack___u64’
include/fix_u32.h:33: error: previous declaration of ‘bb_hack___u64’ was here
make[1]: *** [libbb/loop.o] Error 1
make: *** [libbb] Error 2

Denys, why did you need to mess with this?  It was simple, and it worked 
without bothering us for years.  If BSD can't properly emulate a Linux API 
that says "linux" in the header name, this is BSD's problem.  You broke "make 
defconfig" using the Ubuntu 9.04 host toolchain on the current clean git 
repository.

I spent months getting this can of worms closed last time.  Don't try to "fix" 
broken toolchains, you just break non-broken toolchains and complicate the 
hell out of the code in the process.

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds


More information about the busybox mailing list