[PATCH] testsuite: typo in tr.tests

[Bernhard Reutner-Fischer]

On Thu, Jul 29, 2010 at 02:20:29PM +0200, Denys Vlasenko wrote:
>On Thu, Jul 29, 2010 at 10:27 AM, Leonid Lisovskiy <lly.dev at gmail.com> wrote:
>> As I can see, there were a lot of scripts (expand.tests for example)
>> which uses old scheme:
>>
>> test -f "$bindir/.config" && . "$bindir/.config"
>> ...
>> test x"$CONFIG_UNICODE_SUPPORT" = x"y" \
>> && test x"$CONFIG_UNICODE_USING_LOCALE" != x"y" \
>>
>> probably, it should be converted to new scheme with "optional" clause,
>> but I'm not sure.
>
>I wonder how would you express that UNICODE_USING_LOCALE should NOT be on
>with "optional".
>
>Also, "optional" uses bashism ${var/foo/bar}:
>
>test x"${OPTIONFLAGS/*:$1:*/y}" != x"y"
>
>which was VERY SLOW in ash (it had CUBIC run time growth relative
>OPTIONFLAGS length). I fixed it in ash.
>
>hush does not even support ${var/foo/bar} yet.
>
>I don't like "optional" thing because of these problems.

my initial impl of the formerly "config_is_set" didn't use bashism, but
whatever.

What about the attached that does away with bashism (but taking the
penalty in runtime due to several subshell-spawning) and supports
!SOMETHING ?

HTH && cheers,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-testsuite-fix-bashism-and-support-thing.patch
Type: text/x-diff
Size: 1423 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20100729/403970bc/attachment.bin>