[PATCH] Re: Question about adduser in Busybox

Rob Landley rob at landley.net
Wed Jan 13 16:27:50 UTC 2010


On Monday 11 January 2010 02:32:50 Michael Abbott wrote:
> On Sun, 10 Jan 2010, Tito wrote:
> > On Sunday 10 January 2010 04:25:59 you wrote:
>
> ...
>
> > > Committed to git, thanks!
> >
> > please next time don't strip my
> > signed-off by Tito Ragusa <farmatito at tiscali.it>
> > It is a little satisfaction for non-professional programmers
> > to be mentioned in the git or cvs logs.
> > This little things make our efforts worthwhile.
>
> I second this.  I noticed that my last two patches also lost my signature,
> and forgot to grumble about it at the time.

Doing that also tracks copyright info.  (Most people only ever bothered to add 
their name to the copyright list up top when doing major work on the thing, 
otherwise the list is pointless and unwieldy.)  But source control should have 
a record of who did what, and if you're checking code in from somebody else 
you _really_ need to say who it came from.

See git 73810e8d42de2, 4cb035dd2, 8cedabaee09937, 686298d6fb1, 84790636675409, 
b8cea6dcb39b3c4, and so on.  (Using actual Linux signed-off by lines with email 
addresses are a distinct improvement over the old way, I just wasn't sure 
about the spam status of putting people's email addresses in comments that 
would go in our svn web browser.)

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds



More information about the busybox mailing list