[PATCH] diff portability fixes

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Wed Feb 10 16:43:13 UTC 2010


On Wed, Feb 10, 2010 at 01:24:08PM -0200, Matheus Izvekov wrote:
>> Besides him, nobody will ever check patches for issues besides the
>> current coding style guidelines, so yes, he has to keep an endless
>> churn of patches coming, but that's up to him. The day he stops being
>> interested in that compiler, probably nobody will care anymore, and the
>> patches will stop.
>> Personally, I found Dan's patches to not be very intrusive, he is doing
>> useful work, and I think he deserves the reward.
>
>I disagree. It makes some applets compile on C89, but they are not
>marked as such in any way, and the user has to figure out what to

The only thing that did not compile with C89 was find due to that one
nested func. All the rest compiled fine in C89 last time i needed it.

>disable by reading compiler error messages, and he must be able to
>deduce they are C99 incompatibilities, or else he would miss reporting
>genuine compiler breakages or waste time reporting invalid bugs.
>How many people out there need this anyway?

busybox replaces several packages that are used in bootstrap so it's a
worthwhile thing to attempt to be portable (if it doesn't cost size).


More information about the busybox mailing list