[PATCH] diff portability fixes

Rob Landley rob at landley.net
Sat Feb 6 01:58:40 UTC 2010


On Wednesday 03 February 2010 21:02:08 Denys Vlasenko wrote:
> On Thursday 04 February 2010 02:03, Matheus Izvekov wrote:
> > On 00:12 Thu 04 Feb     , Denys Vlasenko wrote:
> > > On Tuesday 02 February 2010 20:22, Dan Fandrich wrote:
> > > > The recent rewrite of the diff applet has introduced several
> > > > unnecessary C99isms. This patch removes them to improve portability
> > > > across compilers.
> > >
> > > There is a simple bug in the patch:
> >
> > What is the story with C99 and busybox? If we are not supposed to use
> > it, why do we pass -std=gnu99 to gcc?
>
> I feel Dan is fighting an uphill battle here
> (it would be more productive to fix compilers once and for all),
> but as long as code does not get uglier or bigger,
> patches like his are fine with me.

I used to go with the "add enough c99 they stop thinking removing it's somehow 
an option, let alone desirable", but it's your show...

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds


More information about the busybox mailing list