[PATCH] insmod: Do not add a pair of "" around the arguments of the module.

Carmelo AMOROSO carmelo.amoroso at st.com
Tue Aug 24 04:01:13 UTC 2010


If there are some spaces in the insmod command line, then
this will be splitted in single words as separate elements of
argv. It just needs to chain them together in the options string
passed to the sys_init_module syscall.

Signed-off-by: Carmelo Amoroso <carmelo.amoroso at st.com>
---
 modutils/modutils.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/modutils/modutils.c b/modutils/modutils.c
index 2608182..cc718db 100644
--- a/modutils/modutils.c
+++ b/modutils/modutils.c
@@ -71,8 +71,7 @@ char* FAST_FUNC parse_cmdline_module_options(char **argv)
 	optlen = 0;
 	while (*++argv) {
 		options = xrealloc(options, optlen + 2 + strlen(*argv) + 2);
-		/* Spaces handled by "" pairs, but no way of escaping quotes */
-		optlen += sprintf(options + optlen, (strchr(*argv, ' ') ? "\"%s\" " : "%s "), *argv);
+		optlen += sprintf(options + optlen, "%s ", *argv);
 	}
 	return options;
 }
-- 
1.5.5.6



More information about the busybox mailing list