[PATCH] vi: discover window size even on serial consoles

Rob Landley rob at landley.net
Mon Apr 19 23:21:21 UTC 2010


On Monday 19 April 2010 00:07:39 Denys Vlasenko wrote:
> Hi Rob,
>
> Please review/try this patch.
> Under qemu-emulated armv6l, it works for me.
>
> I am going to apply it to git.

You already have CONFIG_FEATURE_EDITING_ASK_TERMINAL, I expect vi should just 
use that config symbol instead of creating another one that does the same thing 
just for it.  (And is it "editing"?  What if top wants to do this?)

Speaking of that symbol, instead of having "more robust in some cases" it 
might be better to point out that this allows busybox to detect the terminal 
size of a serial console.

(Speaking of config symbols, why are "command line editing" and children not 
under the shells menu?  Is that used for something other than command shells?  
And "clean up all memory before exiting" might belong in the debug menu, not 
sure.  And "exec prefers applets" might be a shell thing too, what else would 
be affected by this?)

This patch needs an #ifdefectomy, but lots of the code does now.  I'll have to 
take a weekend at do a lot of that at some point.  No point holding it up for 
that...

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds


More information about the busybox mailing list