[PATCH] ipcalc: fix optional netmask

Steve Bennett steveb at workware.net.au
Wed Apr 7 01:02:02 UTC 2010


netmask should be optional for -b, -n, -p

Signed-off-by: Steve Bennett <steveb at workware.net.au>
---
 networking/ipcalc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/networking/ipcalc.c b/networking/ipcalc.c
index 7855849..1f06c88 100644
--- a/networking/ipcalc.c
+++ b/networking/ipcalc.c
@@ -97,7 +97,7 @@ int ipcalc_main(int argc UNUSED_PARAM, char **argv)
 	if (opt & SILENT)
 		logmode = LOGMODE_NONE; /* suppress error_msg() output */
 	if (opt & (BROADCAST | NETWORK | NETPREFIX)) {
-		if (!argv[0] || !argv[1] || argv[2])
+		if (!argv[0] || (argv[1] && argv[2]))
 			bb_show_usage();
 	} else {
 		if (!argv[0] || argv[1])
-- 
1.5.5.3

Steve
--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/



More information about the busybox mailing list