tar: corrupted octal value in tar header (Apple Snow Leopard)

[Peter Renzland]

On 09  Sep 23, at 11:20 , Denys Vlasenko wrote:

>>>> Since there is no longer a current POSIX tar standard, perhaps it  
>>>> might
>>>> make
>>>> sense to create a Busybox term:
>>>>
>>>> "NEW APPLE COMPATIBILITY" which is equivalent to "OLDGNU  
>>>> COMPATIBILITY".
>>>
>>> I think the question is: do we need to have
>>> FEATURE_TAR_OLDGNU_COMPATIBILITY
>>> at all? Maybe it makes sense to make it unconditionally on.
>>>
>>> It is less than 100 bytes:
>>>
>>> function                                             old     new    
>>> delta
>>> getOctal                                              63       
>>> 57      -6
>>> get_header_tar                                      1612     
>>> 1533     -79
>>>
>>> ------------------------------------------------------------------------------
>>> (add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-85)              
>>> Total: -85
>>> bytes
>>>
>>> What do you think?
>>> --
>>> vda
>>
>> This sounds like a good idea, resulting in greater simplicity and
>> portability.
>
>
> I did not remove FEATURE_TAR_OLDGNU_COMPATIBILITY, but
> I made it so that spaces at the ned of the fields
> will be accepted even with FEATURE_TAR_OLDGNU_COMPATIBILITY off.
> See attached.
>
> Code growth for !FEATURE_TAR_OLDGNU_COMPATIBILITY:
>
> function                                             old     new    
> delta
> get_header_tar                                      1533    1582      
> +49
> getOctal                                              57       
> 63      +6
>
> --
> vda
> <z.diff>

Thanks!!!