show thread as process

[Denys Vlasenko]

On Monday 21 September 2009 12:52, Fabian Meier wrote:
> Hi,
> 
> Thanks, I just tested the patch. It works with CONFIG_DESKTOP. So I
> will have to switch to this option. The binary increases by 5k.
> Is there also noticeable memory & performance loss by switching to
> CONFIG_DESKTOP? The system is a ppc855 60Mhz and 64Mb ram.
> Maybe it is better for me to just patch the procps_scan mask (in bb 1.16.0) with
> 
>     while ((p = procps_scan(p, 0
>             | PSSCAN_PID
>             | PSSCAN_UIDGID
>             | PSSCAN_STATE
>             | PSSCAN_VSZ
>             | PSSCAN_COMM
>             | use_selinux
> #if ENABLE_FEATURE_SHOW_THREADS
>             | PSSCAN_TASKS
> #endif
>     )) != NULL) {
> 
> I will go this way I guess.

Or you may do it properly: enable -T option.

See attached patch.

> Besides, there is a (config) bug in your patch:
> 
>   CC      procps/top.o
> procps/top.c: In function 'top_main':
> procps/top.c:1087: error: assignment of read-only variable 'scan_mask'
> make[1]: *** [procps/top.o] Error 1
> make: *** [procps] Error 2
> 
>  [ ]   Topmem command ('s' key)
> 
>  IF_NOT_FEATURE_TOPMEM(const) unsigned scan_mask = TOP_MASK;

Fixed, thanks.
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5.patch
Type: text/x-diff
Size: 3917 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090921/82314858/attachment.bin>